Contact form bug

[alexgieg]

I've discovered a small bug in Swift's contact form (perhaps WordPress?). If one enters brackets in the subject line, so that the shortcode looks like this:

[contact_form email="example@example.com" subject="[Blah] Something"]

It interprets the closing bracket inside the subject parameter as closing the whole shortcode, so that:

Something"]

Is printed right after the generated form.

I haven't attempted actually using the form to see what'd happen. Better to change the brackets to parenthesis.

[alexgieg]

Another small problem I found while translating the contact form related texts to use it in a pt-BR site. In /lib/plugins/shortcode-ninja/admin-shortcodes.php, lines 1464 and 1472, the e-mail field names "From: " and "Reply-To: " are being translated. This shouldn't happen, as those names are standardized. Translating them would result in odd results, probably preventing the form from working.

[alexgieg]

And a last one: I had to add this to lib/load-core.php at line 38 for the form translation to load:

load_theme_textdomain( 'swiftthemes', TEMPLATEPATH . '/languages' );

This text domain is very small and related almost exclusively to the contact form, so maybe it's mostly left overs from a previous mass replace from 'swiftthemes' to 'swift'?

[alexgieg]

PS.: I found that the incorrect textdomain is limited to /lib/plugins/shortcode-ninja/admin-shortcodes.php, so quite easy to fix. It's just a matter of replacing all instances of 'swiftthemes' (including the single quotes) in the file with 'swift' (including the single quotes). Afterwards the above "load_theme_textdomain" workaround isn't needed anymore.

[Satish]

fixed the issue